Conversation
Contributor
There was a problem hiding this comment.
How about making the connection implement PromisorInterface, so it can return a promise that resolves as soon as the conn is established?
|
Looks like a fairly sensible impl, a few points though:
|
Closed
|
Do not forget to update http client too |
Member
|
This PR seems like a good starting point, thanks @cboden! This PR has been WIP for quite some time now and things have changed considerably since then :-) React now consists of individual components that are maintained individually. Supporting server-side SSL/TLS is now related to the react/socket component. As such, I've just filed a new ticket reactphp/socket#24 to keep track of this, so I suppose it makes sense to focus our SSL/TLS related efforts on this component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2
Seems to be functioning...example works with self signed cert using TLS crypto method.
TODO: