Skip to content

Jsxtags: shaded brackets in JSX, just like TS does.#368

Closed
cristianoc wants to merge 42 commits intomasterfrom
jsxtags
Closed

Jsxtags: shaded brackets in JSX, just like TS does.#368
cristianoc wants to merge 42 commits intomasterfrom
jsxtags

Conversation

@cristianoc
Copy link
Collaborator

No description provided.

cristianoc and others added 30 commits March 9, 2022 13:52
With upper case ids, emit Token.JsxTag
With lower case ids, emit Token.Variable

Still need to do module declarations and expressions (and e.g. open M etc).
This is done in two places:
The textmate grammar handles the cases that can be figured out locally:
- "<" in "<div ..."
- "</"
- "/>"
- "<>"
- "</>"

Semantic highlighting handles the cases that cannot be figured out locally:
- ">" in "<div __props__>"
- ">" in "</div>"

These cases can't be figures out locally as on the lhs of ">" there could be pretty much anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants