ensure updated config is synced on use of restart command#438
Merged
Conversation
…up a few unused things
cristianoc
reviewed
May 30, 2022
cristianoc
approved these changes
May 30, 2022
Collaborator
cristianoc
left a comment
There was a problem hiding this comment.
Looks great.
The only thing that comes to mind, is how to make it completely explicit that the code that follows createLanguageClient is the global state. (which is preserved on restart).
Collaborator
In fact, there's one other small bit of global state: which is followed by a bunch of commented out code. Then the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial read configuration was never refreshed as the restart command runs, which means you'd always get potentially stale initial config after a restart.
Also clean up a few init things that I suspect has never been cleaned up after the initial adaption of the LS client example.