Add markdown code block syntax highlight support#97
Merged
zth merged 15 commits intorescript-lang:masterfrom Jul 25, 2022
Merged
Add markdown code block syntax highlight support#97zth merged 15 commits intorescript-lang:masterfrom
zth merged 15 commits intorescript-lang:masterfrom
Conversation
Member
|
Hey, thanks! Though is this the idiomatic way of doing it? It seems typescript's grammar repo doesn't have such thing? |
Contributor
Author
|
I rewrite the file from the vscode-reasonml repo, just some minor changes. |
Member
|
@zth can we get semantic highlighting in markdown blocks as well? |
Member
|
@fhammerschmidt I'm not sure. Does TS do it? |
Contributor
|
I was looking for how vscode apply syntax highlighting in markdown. It doesn't use semantic highlighting just TexMate grammar. Here are supported languages. |
Member
Member
|
I'm thinking we should merge this as is. I agree that some highlighting is better than none. Ok with you @cristianoc ? Side note: There's more interesting things we can do eventually to better support md, like formatting code inside of ReScript md blocks. |
…ng from the language client. This just ensures that the server tells the client that sending codeLens requests is fine. Next we'll implement the actual functionality that resolves the code leneses.
…rinter towards printing function types for code lenses on one line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.