Skip to content

Comments

feat(mysql): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.1#11

Merged
atzoum merged 4 commits intomainfrom
dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0
May 20, 2024
Merged

feat(mysql): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.1#11
atzoum merged 4 commits intomainfrom
dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2024 •
edited by atzoum
Loading

Bumps github.com/go-sql-driver/mysql from 1.7.1 to 1.8.1.

Release notes

Sourced from github.com/go-sql-driver/mysql's releases.

v1.8.0

What's Changed

Major changes

  • Use SET NAMES charset COLLATE collation. by @​methane in go-sql-driver/mysql#1437

    • Older go-mysql-driver used collation_id in the handshake packet. But it caused collation mismatch in some situation.
    • If you don't specify charset nor collation, go-mysql-driver sends SET NAMES utf8mb4 for new connection. This uses server's default collation for utf8mb4.
    • If you specify charset, go-mysql-driver sends SET NAMES <charset>. This uses the server's default collation for <charset>.
    • If you specify collation and/or charset, go-mysql-driver sends SET NAMES charset COLLATE collation.

  • PathEscape dbname in DSN. by @​methane in go-sql-driver/mysql#1432

    • This is backward incompatible in rare case. Check your DSN.

  • Drop Go 1.13-17 support by @​methane in go-sql-driver/mysql#1420

    • Use Go 1.18+

  • Parse numbers on text protocol too by @​methane in go-sql-driver/mysql#1452

    • When text protocol is used, go-mysql-driver passed bare []byte to database/sql for avoid unnecessary allocation and conversion.
    • If user specified *any to Scan(), database/sql passed the []byte into the target variabe.
    • This confused users because most user doesn't know when text/binary protocol used.
    • go-mysql-driver 1.8 converts integer/float values into int64/double even in text protocol. This doesn't increase allocation compared to []byte and conversion cost is negilible.

  • New options start using the Functional Option Pattern to avoid increasing technical debt in the Config object. Future version may introduce Functional Option for existing options, but not for now.

Other changes

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 12, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch 2 times, most recently from 5448b78 to 369ffd8 Compare March 14, 2024 11:33
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch 3 times, most recently from 10381a8 to f06356a Compare March 21, 2024 10:36
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from 1b86e0f to 073b6e3 Compare March 26, 2024 07:11
@codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.31915% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 85.46%. Comparing base (eda4cf6) to head (abb3d69).

Files Patch % Lines
sqlconnect/internal/mysql/legacy_mappings.go 54.16% 9 Missing and 2 partials ⚠️
sqlconnect/internal/mysql/mappings.go 40.00% 4 Missing and 2 partials ⚠️
sqlconnect/internal/sshtunnel/tcp_tunnel.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   86.03%   85.46%   -0.58%     
==========================================
  Files          75       75              
  Lines        3022     3068      +46     
==========================================
+ Hits         2600     2622      +22     
- Misses        274      294      +20     
- Partials      148      152       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 1, 2024

A newer version of github.com/go-sql-driver/mysql exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@atzoum atzoum changed the title chore(deps): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 feat(mysql): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 Apr 8, 2024
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch 3 times, most recently from b22ad87 to 927e6fb Compare April 9, 2024 10:50
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from 927e6fb to 03f0c32 Compare April 16, 2024 10:10
@dependabot dependabot bot requested a review from atzoum as a code owner April 16, 2024 10:10
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from 03f0c32 to 1a31bb2 Compare April 29, 2024 13:06
@github-actions
Copy link

github-actions bot commented May 20, 2024

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label May 20, 2024
@atzoum atzoum removed the Stale label May 20, 2024
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch 2 times, most recently from 1108f0d to 1f315bb Compare May 20, 2024 06:12
@atzoum atzoum changed the title feat(mysql): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 feat(mysql): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.1 May 20, 2024
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch 3 times, most recently from 8abd288 to 1a2638e Compare May 20, 2024 09:49
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from 1a2638e to d7e26ea Compare May 20, 2024 10:19
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from d6327ae to fdb3345 Compare May 20, 2024 10:57
dependabot bot and others added 4 commits May 20, 2024 17:27
@dependabot @atzoum
chore(deps): bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0
e5c9eba 
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.7.1 to 1.8.0.
- [Release notes](https://github.com/go-sql-driver/mysql/releases)
- [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md)
- [Commits](go-sql-driver/mysql@v1.7.1...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/go-sql-driver/mysql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@atzoum
chore: adapt mysql mappings to new driver behaviour
ab2897f
@atzoum
chore: bump mysql to 1.8.1
179a8e2
@atzoum
fix: tcp tunnel wait
abb3d69
@atzoum atzoum force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from fdb3345 to abb3d69 Compare May 20, 2024 11:57
@atzoum atzoum merged commit de51b3a into main May 20, 2024
@atzoum atzoum deleted the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch May 20, 2024 12:42
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request May 20, 2024
Merged
atzoum pushed a commit that referenced this pull request May 20, 2024
@devops-github-rudderstack
chore: release 1.2.0 (#63)
89fa9de 
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](v1.1.7...v1.2.0)
(2024-05-20)


### Features

* **bigquery:** bump cloud.google.com/go/bigquery from 1.59.1 to 1.61.0
([#56](#56))
([30e3030](30e3030))
* **databricks:** bump github.com/databricks/databricks-sql-go from
1.5.3 to 1.5.4
([#61](#61))
([ec3fb29](ec3fb29))
* **databricks:** bump github.com/databricks/databricks-sql-go from
1.5.4 to 1.5.5
([#66](#66))
([000e3b4](000e3b4))
* **mysql:** bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.1
([#11](#11))
([de51b3a](de51b3a))
* **redshift:** bump github.com/aws/aws-sdk-go-v2/service/redshiftdata
from 1.25.4 to 1.25.7
([#75](#75))
([3036555](3036555))
* **snowflake:** bump github.com/snowflakedb/gosnowflake from 1.7.2 to
1.9.0 ([#33](#33))
([5b926c8](5b926c8))
* **snowflake:** bump snowflake to v1.10.0
([#79](#79))
([b205e59](b205e59))
* **trino:** bump github.com/trinodb/trino-go-client from 0.313.0 to
0.315.0 ([#64](#64))
([b15133b](b15133b))


### Miscellaneous

* **bigquery:** downgrade bigquery from 1.61.0 to 1.60.0
([#77](#77))
([eda4cf6](eda4cf6))
* bump bigquery to v1.61.0
([#78](#78))
([3ad5159](3ad5159))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atzoum atzoum atzoum approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@atzoum