Skip to content

feat: add ListCatalogs method to CatalogAdmin interface#427

Merged
am6010 merged 9 commits intomainfrom
feature/pro-5230-implement-listcatalogs-method-in-catalogadmin-interface
Feb 12, 2026
Merged

feat: add ListCatalogs method to CatalogAdmin interface#427
am6010 merged 9 commits intomainfrom
feature/pro-5230-implement-listcatalogs-method-in-catalogadmin-interface

Conversation

@am6010
Copy link
Contributor

@am6010 am6010 commented Feb 3, 2026

🔒 Scanned for secrets using gitleaks 8.28.0

Description

Extend CatalogAdmin to support listing available catalogs/databases
linked to credentials. Enables discovery of accessible catalogs across
all supported database types.

  • Add CatalogRef type for catalog references
  • Implement ListCatalogs() method returning []CatalogRef
  • Add database-specific SQL overrides for PostgreSQL, MySQL, Snowflake,
    Redshift, Databricks, Trino, and BigQuery
  • Filter system catalogs (information_schema, pg_catalog, etc.)
  • Return empty list on permission errors or unsupported features
  • Add integration test coverage

Linear Ticket

ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

🔒 Scanned for secrets using gitleaks 8.28.0
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.92%. Comparing base (e6df6b6) to head (dc676f3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sqlconnect/internal/base/catalog_admin.go 78.94% 4 Missing and 4 partials ⚠️
sqlconnect/internal/trino/db.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   84.86%   84.92%   +0.05%     
==========================================
  Files          90       91       +1     
  Lines        4010     4092      +82     
==========================================
+ Hits         3403     3475      +72     
- Misses        451      457       +6     
- Partials      156      160       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@am6010 am6010 marked this pull request as ready for review February 5, 2026 12:00
@am6010 am6010 requested a review from atzoum as a code owner February 5, 2026 12:00
🔒 Scanned for secrets using gitleaks 8.28.0
🔒 Scanned for secrets using gitleaks 8.28.0
@am6010 am6010 requested a review from atzoum February 11, 2026 08:46
Copy link
Collaborator

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment about reusing existing functionality

🔒 Scanned for secrets using gitleaks 8.28.0
@am6010 am6010 merged commit 2899478 into main Feb 12, 2026
23 checks passed
@am6010 am6010 deleted the feature/pro-5230-implement-listcatalogs-method-in-catalogadmin-interface branch February 12, 2026 11:07
atzoum pushed a commit that referenced this pull request Feb 12, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.24.0](v1.23.0...v1.24.0)
(2026-02-12)


### Features

* add ListCatalogs method to CatalogAdmin interface
([#427](#427))
([2899478](2899478))
* **databricks:** bump github.com/databricks/databricks-sql-go from
1.8.0 to 1.9.0
([#431](#431))
([e6df6b6](e6df6b6))


### Miscellaneous

* **deps:** bump cloud.google.com/go/bigquery from 1.72.0 to 1.73.1
([#429](#429))
([9c1603f](9c1603f))
* **deps:** bump github.com/rudderlabs/rudder-go-kit from 0.71.0 to
0.71.1 ([#432](#432))
([82b3c0d](82b3c0d))
* **deps:** bump step-security/harden-runner from 2.14.1 to 2.14.2
([#428](#428))
([a3487e3](a3487e3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: rudderstack-github-actions[bot] <236995729+rudderstack-github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments