Skip to content

fix(redshift): listcolumns doesn't return any results for views with no schema binding#91

Merged
Vikas26021999 merged 3 commits intomainfrom
fix.redshiftColumns
Jun 7, 2024
Merged

fix(redshift): listcolumns doesn't return any results for views with no schema binding#91
Vikas26021999 merged 3 commits intomainfrom
fix.redshiftColumns

Conversation

@Vikas26021999
Copy link
Contributor

@Vikas26021999 Vikas26021999 commented Jun 6, 2024

Description

Using SVV_COLUMNS for listing column which supports local and external tables and views, including late-binding views.

Linear Ticket

REV-1042

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Vikas26021999 Vikas26021999 requested a review from atzoum as a code owner June 6, 2024 00:10
@atzoum atzoum changed the title fix: non schema binded views columns fix fix(redshift): ListColumns doesn't return any results for views with no schema binding Jun 6, 2024
@Vikas26021999 Vikas26021999 changed the title fix(redshift): ListColumns doesn't return any results for views with no schema binding fix(redshift): listcolumns doesn't return any results for views with no schema binding Jun 6, 2024
@codecov
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (f210281) to head (53092d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   85.40%   85.42%   +0.02%     
==========================================
  Files          75       75              
  Lines        3042     3047       +5     
==========================================
+ Hits         2598     2603       +5     
  Misses        292      292              
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vikas26021999 Vikas26021999 merged commit 9489790 into main Jun 7, 2024
@Vikas26021999 Vikas26021999 deleted the fix.redshiftColumns branch June 7, 2024 07:05
Vikas26021999 pushed a commit that referenced this pull request Jun 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](v1.2.0...v1.3.0)
(2024-06-07)


### Features

* **databricks:** bump github.com/databricks/databricks-sql-go from
1.5.5 to 1.5.6
([#86](#86))
([b20a89e](b20a89e))
* **snowflake:** bump github.com/snowflakedb/gosnowflake from 1.10.0 to
1.10.1 ([#88](#88))
([f210281](f210281))


### Bug Fixes

* **redshift:** listcolumns doesn't return any results for views with no
schema binding
([#91](#91))
([9489790](9489790))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments