Prevent other crates from implementing our traits#38
Merged
LukeMathWalker merged 3 commits intomasterfrom Apr 12, 2019
Merged
Conversation
This allows us to freely add new functionality to the traits without breaking changes.
bb98b7d to
5c63f4d
Compare
This still prevents other crates from implementing our traits, but it has the advantage that it also prevents them from calling the `__private__` methods.
LukeMathWalker
approved these changes
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to freely add new functionality to the traits without breaking changes.
Fixes #34.