Conversation
…stances marked with mismatching `synapse.io/operator` labels Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logic error in operator label checking that prevented the operator from properly ignoring workflows and workflow instances with mismatching synapse.io/operator labels. The fix ensures that when a resource has an operator label that doesn't match the current operator's qualified name, the operator will correctly ignore that resource rather than claiming it.
- Fixed conditional logic in
TryClaimAsyncandTryReleaseAsyncmethods to properly compare operator labels - Updated both WorkflowController and WorkflowInstanceController with the same logic correction
- Changed early return behavior to properly handle mismatched operator labels
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| WorkflowInstanceController.cs | Fixed operator label comparison logic in TryClaimAsync and TryReleaseAsync methods |
| WorkflowController.cs | Fixed operator label comparison logic in TryClaimAsync and TryReleaseAsync methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
synapse.io/operatorlabelsFixes #515