Enabled label management when creating or editing a workflow#533
Merged
Enabled label management when creating or editing a workflow#533
Conversation
…r editing workflows Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
c654349 to
0d7af28
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables label and annotation management when creating or editing workflows in the Synapse Dashboard. It replaces the simplified operator selection with comprehensive label/annotation management through a new dictionary editor component.
- Introduces a
DictionaryEditorcomponent for managing key-value pairs (labels and annotations) - Refactors workflow creation and instance creation to use labels/annotations instead of operator strings
- Updates UI layout with improved CSS classes and styling for better organization
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/dashboard/Synapse.Dashboard/wwwroot/css/table.scss |
Adds utility CSS for table column width fitting |
src/dashboard/Synapse.Dashboard/wwwroot/css/app.scss |
Adds flex utilities and updates problem display styling |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/View.razor |
Updates workflow instance creation calls to pass labels/annotations |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/Store.cs |
Refactors instance creation to use labels/annotations instead of operator string |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor |
Integrates dictionary editor for labels/annotations in workflow creation |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/Store.cs |
Adds label/annotation management methods and updates save logic |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/State.cs |
Adds Labels and Annotations properties, removes Operator property |
src/dashboard/Synapse.Dashboard/Components/DictionaryEditor/DictionaryEditor.razor |
New reusable component for editing key-value dictionaries |
src/dashboard/Synapse.Dashboard/Components/CreateWorkflowInstanceDialog/CreateWorkflowInstanceParameters.cs |
Replaces Operator property with Labels and Annotations |
src/dashboard/Synapse.Dashboard/Components/CreateWorkflowInstanceDialog/CreateWorkflowInstanceDialog.razor |
Integrates dictionary editor for instance creation dialog |
Comments suppressed due to low confidence (2)
src/dashboard/Synapse.Dashboard/Components/DictionaryEditor/DictionaryEditor.razor:64
- The method name 'AddLabel' is misleading since this component is a generic dictionary editor that can handle both labels and annotations. Consider renaming to 'AddEntry' to match the component's generic purpose.
private void AddLabel()
src/dashboard/Synapse.Dashboard/Components/DictionaryEditor/DictionaryEditor.razor:76
- The method name 'RemoveLabel' is misleading since this component is a generic dictionary editor that can handle both labels and annotations. Consider renaming to 'RemoveEntry' to match the component's generic purpose.
private void RemoveLabel(string key)
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor
Outdated
Show resolved
Hide resolved
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor
Outdated
Show resolved
Hide resolved
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Adds the ability to add/remove labels from a workflow.
Special notes for reviewers:
Additional information (if needed):