Allow additional configuration metadata to VM during deployment#19
Closed
Allow additional configuration metadata to VM during deployment#19
Conversation
yadvr
reviewed
Jul 25, 2018
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
Show resolved
Hide resolved
yadvr
reviewed
Jul 25, 2018
api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
Show resolved
Hide resolved
yadvr
reviewed
Jul 25, 2018
yadvr
reviewed
Jul 25, 2018
nvazquez
reviewed
Aug 2, 2018
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
Outdated
Show resolved
Hide resolved
nvazquez
reviewed
Aug 2, 2018
...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
Outdated
Show resolved
Hide resolved
nvazquez
reviewed
Aug 2, 2018
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
Outdated
Show resolved
Hide resolved
nvazquez
reviewed
Aug 2, 2018
nvazquez
reviewed
Aug 2, 2018
nvazquez
reviewed
Aug 2, 2018
nvazquez
reviewed
Aug 2, 2018
a107bc3 to
43103ff
Compare
nvazquez
reviewed
Aug 15, 2018
...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
Outdated
Show resolved
Hide resolved
nvazquez
reviewed
Aug 15, 2018
nvazquez
reviewed
Aug 15, 2018
yadvr
requested changes
Aug 23, 2018
Member
yadvr
left a comment
There was a problem hiding this comment.
Overall good work Dingane, left some comments and TODOs.
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
Show resolved
Hide resolved
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
Outdated
Show resolved
Hide resolved
Member
|
@dhlaluku can you also rebase against latest master and fix conflicts. |
nvazquez
reviewed
Aug 28, 2018
nvazquez
reviewed
Aug 28, 2018
badb526 to
bec3e28
Compare
96189b3 to
0fa8aa0
Compare
0fa8aa0 to
3f5c7e9
Compare
65921a2 to
1fa4375
Compare
Author
|
@nvazquez @DaanHoogland, please review |
Author
|
@nvazquez @DaanHoogland @rhtyd may you please have a look at this PR. @rhtyd you requested changes a while back when you reviewed this PR, please have another and advice on any revisions required. |
96dc83d to
fcb7d86
Compare
| host = list_hosts( | ||
| self.apiclient, | ||
| id=host_id, | ||
| hypervisor='kvm') |
Member
There was a problem hiding this comment.
This shouldn't be 'kvm' hardcoded, but instead use 'testClient.getHypervisorInfo()' to set a class var. In this case hypervisors !=kvm will run
Author
There was a problem hiding this comment.
Done, now using self.hypervisor.lower()
4d2cc85 to
4d1d4f4
Compare
Fix small UI issue when dedicating public IR range for system VMs: Unable to execute API command createvlaniprange due to invalid value. Invalid parameter domainid value=undefined due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class. Fixes: apache#3485
* Add revoke certificates API * Add background task to sync certificates * Fix marvin test and revoke certificate * Fix certificate sent to hypervisor was missing headers * Fix background task for uploading certificates to hosts
* Allow users to share templates with Accounts or Projects through the updateTemplate permissions API * Change behaviour to show only supported projects and accounts with update template permissions * Allow admins to see accounts dropdown and only hide lists for users * Don't allow sharing project owned templates as you cannot retrieve them in list api calls
…he#3504) Set integration.api.port to (0) zero as default. CloudStack provides CloudStack API Unauthenticated Access through port 8096. It should not be open to the Internet in any case.
During volume stats calculation, if a volume has more than one disk in the chain-info it is not used to sum the physical and virtual size in the loop, instead any previous entry was overwritten by the last disk. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
…ot started before (apache#3494) When VM is created but not started on any host, attaching a volume on it causes the maximum number of allowed volumes to be 6 (hardcoded).
… vlans when adding ipranges (apache#3430) Fixes: apache#3114 When adding iprange for VLANs there are 3 cases - VLAN under consideration has a tag (like 101) VLAN under consideration has a tag but as a range (like 101-124) VLAN is untagged (i.e. id is "untagged") Before adding iprange we have to check for possible overlaps and throw exception. This needs to be done as follows - If VLAN Tag ID is numeric or a range we need to call UriUtils.checkVlanUriOverlapmethod which internally tries to expand the range as verifies if there are overlaps. If URI overlaps (i.e. there are overlapping VLAN tags) we then need to verify if the iprange being added overlaps with previously added ranges. If there are no overlapping tags we simply need to test for public networks being present in the VLAN. A Regression was introduced in 41fdb88#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174 which caused comparing 'untagged' string as a numeric VLAN Tag range and and attempted expanding it to test overlap in UriUtils.checkVlanUriOverlap. To fix the bug in the issue, we need to handle the untagged case separately as it's non-numeric tag in code. For untagged VLANs and overlapping VLAN URIs we need to check for ipranges and gateways which happens naturally after this change. For tagged VLANs with non-overlapping URIs we need to check if there is a public network.
Member
Update marvin tests to use white list
* Add new marvin negative tests cases * Remove hard-coded hypervisor types in marvin tests
6e864b7 to
d0fcd97
Compare
|
Closing this and opening a public PR as advised. |
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
shwstppr
pushed a commit
that referenced
this pull request
Jul 27, 2021
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
yadvr
pushed a commit
that referenced
this pull request
Oct 16, 2024
[4.18] server, api: account and api entity access improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, CloudStack does not allow additional configuration metadata to guest VMs during deployment. This feature aims to provide operators the functionality to pass arbitrary additional configuration metadata that will be included everytime the guest VM is started.
Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
Testing