Skip to content

[WIP] Get diagnostics data API (review)#21

Closed
dhlaluku wants to merge 11 commits intomasterfrom
get-diagnostics-data
Closed

[WIP] Get diagnostics data API (review)#21
dhlaluku wants to merge 11 commits intomasterfrom
get-diagnostics-data

Conversation

@dhlaluku
Copy link

@dhlaluku dhlaluku commented Aug 31, 2018

Description

Get diagnostics data API command from system VMs

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@dhlaluku dhlaluku changed the title [WIP] Get diagnostics data (review) [WIP] Get diagnostics data API (review) Aug 31, 2018
@dhlaluku dhlaluku force-pushed the get-diagnostics-data branch 2 times, most recently from b3353cb to 34904ae Compare September 24, 2018 14:45
@dhlaluku dhlaluku force-pushed the get-diagnostics-data branch from 268cf3a to eeb9be3 Compare October 15, 2018 10:24
@dhlaluku dhlaluku closed this Nov 29, 2018
shwstppr pushed a commit that referenced this pull request Nov 3, 2020
@Pearl1594
FR563 - Capacity recalculation on migration - considering overcommit …
4712856 
…ratio (#21)

https://shapeblue.atlassian.net/browse/FRO-916

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@onitake @yadvr
README: add build dependencies to package.json and document productio…
7ea78b9 
…n build properly (#21)

Fixes: #12

With build tooling added to the dev dependencies, it is no longer necessary to install system-wide.
This is particularly useful for production builds, where system-wide package pollution is highly discouraged or even prohibited.

npm@next, vue-cli and ncu may still be useful to developers, but they shouldn't be part of the build instructions. A separate readme update is on the way.

The PR now also includes a readme update to clarify which tools should be installed when.
Production builds do not need global tool installs.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr pushed a commit that referenced this pull request Aug 16, 2021
@Pearl1594 @shwstppr
FR563 - Capacity recalculation on migration - considering overcommit …
8dfd125 
…ratio (#21)

https://shapeblue.atlassian.net/browse/FRO-916

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dhlaluku