use the app menu bar for Linux instead of the default chrome#139
Merged
use the app menu bar for Linux instead of the default chrome#139
Conversation
|
How does this interact with themes with custom title bar layouts? |
Owner
Author
Without examples it's hard to say specifically, but we disable the frame so this becomes more of a "chromeless" window, and makes it more consistent with how the app works on Windows. |
fb1d4e6 to
5d1d4b7
Compare
shiftkey
added a commit
that referenced
this pull request
May 28, 2019
shiftkey
added a commit
that referenced
this pull request
May 30, 2019
shiftkey
added a commit
that referenced
this pull request
Jun 5, 2019
shiftkey
added a commit
that referenced
this pull request
Jun 6, 2019
shiftkey
added a commit
that referenced
this pull request
Jun 12, 2019
shiftkey
added a commit
that referenced
this pull request
Jun 17, 2019
shiftkey
added a commit
that referenced
this pull request
Jun 19, 2019
trxcllnt
added a commit
to trxcllnt/desktop
that referenced
this pull request
Jul 1, 2019
…hiftkey#139)" This reverts commit e3f32b5.
shiftkey
added a commit
that referenced
this pull request
Jul 2, 2019
shiftkey
added a commit
that referenced
this pull request
Jul 2, 2019
shiftkey
added a commit
that referenced
this pull request
Oct 14, 2019
shiftkey
added a commit
that referenced
this pull request
Feb 4, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 6, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 6, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 6, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 7, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 7, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 7, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 7, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 7, 2020
shiftkey
added a commit
that referenced
this pull request
Feb 21, 2020
shiftkey
added a commit
that referenced
this pull request
Mar 2, 2020
shiftkey
added a commit
that referenced
this pull request
Mar 11, 2020
shiftkey
added a commit
that referenced
this pull request
Mar 20, 2020
shiftkey
added a commit
that referenced
this pull request
Mar 26, 2020
shiftkey
added a commit
that referenced
this pull request
Mar 26, 2020
shiftkey
added a commit
that referenced
this pull request
Mar 26, 2020
4 tasks
shiftkey
added a commit
that referenced
this pull request
Apr 2, 2020
2 tasks
shiftkey
added a commit
that referenced
this pull request
Apr 6, 2020
|
I don't see the menuWhy was this reverted? Please at least make it an option... |
Owner
Author
|
@Heath123 please open a fresh issue and share some details about your setup (the version installed, what you expect to see, what is actually visible, screenshots, etc) |
Owner
Author
Yes, based on the feedback from #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #114
Description
Currently when you run the app on Linux it uses the default chrome of the shell to render the menu and the minimize/maximize/close buttons:
This PR updates the Linux build to use the custom app menu we use on Windows, which should help with making the app feel more polished:
Release notes
Notes:
[Improved] use styled app menu rather than native chrome on Linux