tuf Updater: fix snapshot version rollback case#1061
Merged
loosebazooka merged 1 commit intosigstore:mainfrom Sep 2, 2025
Merged
tuf Updater: fix snapshot version rollback case#1061loosebazooka merged 1 commit intosigstore:mainfrom
loosebazooka merged 1 commit intosigstore:mainfrom
Conversation
The snapshot version listed in timestamp must never decrease (except if timestamp keys are rotated but that in that case local timestamp is not used at all). This was a deviation from TUF specification but not a very serious one in context: In sigstores TUF repository the Timestamp/snapshot keys are exposed in the same environments so compromise in one means compromise for both (because of this they are in fact the same key). So tricks like snapshot version rollback are not that relevant. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Member
Author
|
The logs are a little light on details but my first guess is this examples.yaml failure is something unrelated? |
Member
Author
|
oh, I guess the example test uses the workflow identity to sign so they just fail for all PRs from forks |
Member
Yeah, that's something I've been meaning to fix, but not pressing. |
loosebazooka
approved these changes
Sep 2, 2025
Member
loosebazooka
left a comment
There was a problem hiding this comment.
This is so simple. Dunno why we never handled it 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot version listed in timestamp must never decrease (except if timestamp keys are rotated but that in that case local timestamp is not used at all).
This was a deviation from TUF specification but not a very serious one in context: In sigstores TUF repository the Timestamp/snapshot keys are exposed in the same environments so compromise in one means compromise for both (because of this they are in fact the same key). So tricks like snapshot version rollback are not that relevant.