Merged
Conversation
patflynn
reviewed
Nov 4, 2024
f6144d3 to
ffff862
Compare
patflynn
reviewed
Nov 4, 2024
sigstore-java/src/test/java/dev/sigstore/tuf/FileSystemTufStoreTest.java
Outdated
Show resolved
Hide resolved
ffff862 to
dd4f1e9
Compare
- don't persist N.root.json, could clash with a delegation - validate at parsetime the type of meta file - generify metastore a bit more, force updater to clear the right meta - validate any bootstrapped root at update start time Signed-off-by: Appu Goundan <appu@google.com>
dd4f1e9 to
ed37516
Compare
patflynn
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perform an update on meta if download target is called directly and we haven't updated yetmore issues found during conformance, maybe I should just merge the conformance test suite in and fix these as I go from now on.