Conversation
patflynn
previously approved these changes
Nov 20, 2024
| @@ -234,16 +235,23 @@ void verifyDelegate( | |||
| Map<String, Key> publicKeys, | |||
Collaborator
There was a problem hiding this comment.
github really doesn't want me commenting on non changed lines or something, but line 230 @throws is I guess out of date?
Member
Author
There was a problem hiding this comment.
oh shoot, yeah lemme fix that
05294d5 to
3da608a
Compare
patflynn
previously approved these changes
Nov 20, 2024
This isn't a security concern, our looping didn't actually allow re-use of keys. But we weren't exactly according to spec. Signed-off-by: Appu Goundan <appu@google.com>
1169e2d to
602aa10
Compare
patflynn
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a security concern, our looping didn't actually allow re-use of keys. But we weren't exactly according to spec.