chore: use Gradle Java toolchains for the build and test execution#923
Merged
vlsi merged 2 commits intosigstore:mainfrom Mar 11, 2025
Merged
chore: use Gradle Java toolchains for the build and test execution#923vlsi merged 2 commits intosigstore:mainfrom
vlsi merged 2 commits intosigstore:mainfrom
Conversation
Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
d570201 to
3ab75f6
Compare
loosebazooka
previously approved these changes
Mar 7, 2025
It enables decoupling of the build JVM vs test JVM. By default we use Java 17 for the build and target with --release 11. Then we vary Java version when running tests Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
vlsi
commented
Mar 7, 2025
| # if you need to skip staging due to flakiness use "-PskipStaging" | ||
| - name: Test sigstore-java | ||
| run: ./gradlew build | ||
| run: ./gradlew build -Porg.gradle.java.installations.auto-download=false -PjdkTestVersion=${{ matrix.java-version }} |
Collaborator
Author
There was a problem hiding this comment.
@loosebazooka , here's how we execute tests with a given Java version even though we always build with Java 17
Member
|
I think you cam merge when ready without examples. I'm working on fixing examples for external contributors using the conformance token. |
loosebazooka
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It decouples the build JVM from the test JVM.
By default we use Java 17 for the build and target with
--release 11.Then we vary Java version when running tests.
You could control JDK versions with the following Gradle properties:
targetJavaVersion. Java version for source and target compatibilityjdkBuildVersion. Defaults to 17. JDK version to use for building $projectName. If the value is 0, then the current Java is used.jdkBuildVendor. JDK vendor to use buildingjdkBuildImplementation. Vendor-specific virtual machine implementation to use buildingjdkTestVersion. Defaults tojdkBuildVersion. JDK version to use for testing.jdkTestVendor. Defaults tojdkBuildVendor. JDK vendor to use testingjdkTestImplementation. Defaults tojdkBuildImplementation. Vendor-specific virtual machine implementation to use testingRelease Note
NONE
Documentation
NONE