Make token string oidc client available outside of cli#925
Merged
Conversation
Signed-off-by: Appu Goundan <appu@google.com>
vlsi
approved these changes
Mar 11, 2025
Member
Author
|
@vlsi can we make this an optional input for sigstore-gradle ? It will help us fix tests on forked requests? |
Collaborator
|
I don't fully get what you mean by "optional input for sigstore-gradle". Do you mean Gradle should be aware the actual value can differ across executions? |
Member
Author
|
Sorry, no I mean, in https://github.com/sigstore/sigstore-java/blob/main/sigstore-gradle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/OidcClientExtension.kt and then I'll configure it for the examples dir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vlsi this is step towards making examples work of fork PRs. Once this is in, we need to add an equivalent gradle oidc thing and then inject the token from conformance into it. wdyt?