Conversation
aaronlew02
requested changes
May 9, 2025
sigstore-java/src/main/java/dev/sigstore/trustroot/SigstoreConfigurationException.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Appu Goundan <appu@google.com>
eaae0c0 to
d44797f
Compare
Hayden-IO
approved these changes
May 9, 2025
| * @param apiVersions an list of api version this clients supports | ||
| * @return A service if found | ||
| */ | ||
| static Optional<Service> select(List<Service> services, List<Integer> apiVersions) { |
Collaborator
There was a problem hiding this comment.
LGTM. Also we'll need to group by operator once sigstore/protobuf-specs#634 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First part of #954
Add in class to store the signing config to later plumb into our client parts
Release Note
Documentation