Skip to content

Comments

Update google-java-format to 1.24.0#957

Merged
loosebazooka merged 1 commit intomainfrom
update-google-java-format
May 13, 2025
Merged

Update google-java-format to 1.24.0#957
loosebazooka merged 1 commit intomainfrom
update-google-java-format

Conversation

@loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented May 12, 2025

1.25.0+ require a minimum java build version of 17, so we can update to latest as we upgrade our build.

@loosebazooka
Update google-java-format to 1.24.0
845297d 
1.25.0 require a minimum java build version of 17, so we
can update to latest as we upgrade our build.

Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka requested review from aaronlew02 and vlsi May 12, 2025 20:07
aaronlew02
aaronlew02 approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@aaronlew02 aaronlew02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loosebazooka loosebazooka merged commit dd78f82 into main May 13, 2025
26 checks passed
@loosebazooka loosebazooka deleted the update-google-java-format branch May 13, 2025 15:46
@vlsi
Copy link
Collaborator

vlsi commented May 13, 2025

What do you mean by 1.25.0+ require a minimum java build version of 17?

We currently use Java 17 for the build (still target 11).
We could even bump to "require Java 21 for the build" and still target --release 11.

@loosebazooka
Copy link
Member Author

loosebazooka commented May 13, 2025

I thought we still build with 11 in our matrix

@vlsi
Copy link
Collaborator

vlsi commented May 13, 2025

No no no. We use the latest and greatest javac compiler, and we use --release 11 so it produces Java 11-compatible bytecode. This should reduce the number of bugs we face when we use old javac.

See #923

In practice, you could launch the build with ./gradlew -PjdkBuildVersion=21 jar to build the jars with javac 21.

I've moved pgjdbc to use javac 21 recently: pgjdbc/pgjdbc#3612, and it might be time to bump the build JDK for sigstore-java as well.

That's cool, isn't it?

@loosebazooka
Copy link
Member Author

loosebazooka commented May 13, 2025

oh yeah, I guess I vaguely recall this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlsi vlsi vlsi approved these changes

@aaronlew02 aaronlew02 aaronlew02 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loosebazooka @vlsi @aaronlew02