Merged
Conversation
7201095 to
52de8bd
Compare
Hayden-IO
reviewed
May 14, 2025
Collaborator
Hayden-IO
left a comment
There was a problem hiding this comment.
This is really great work! I can't speak much to Java style, I'll let Appu chime in there.
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClient.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampResponse.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Show resolved
Hide resolved
Member
loosebazooka
left a comment
There was a problem hiding this comment.
Just some preliminary comments, I'll go over the logic in TimestampClientHttp on a second pass.
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClient.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClient.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampRequest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampRequest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampClientHttpTest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampRequest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampClientHttpTest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampVerifierTest.java
Outdated
Show resolved
Hide resolved
ce3d63d to
2eaaa55
Compare
Member
loosebazooka
left a comment
There was a problem hiding this comment.
looks good, just some minor things
sigstore-java/src/main/java/dev/sigstore/trustroot/SigstoreTrustedRoot.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/trustroot/SigstoreTrustedRoot.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
2eaaa55 to
011ce8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Lew 64337293+aaronlew02@users.noreply.github.com
Closes: #958
Summary
Add a
TimestampClientto request a timestamp from a timestamp authority and aTimestampVerifierto verify a timestamp.