Update Examples action to run on Windows, MacOs, and Linux#974
Merged
loosebazooka merged 6 commits intosigstore:mainfrom May 30, 2025
Merged
Update Examples action to run on Windows, MacOs, and Linux#974loosebazooka merged 6 commits intosigstore:mainfrom
loosebazooka merged 6 commits intosigstore:mainfrom
Conversation
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Member
|
Okay, I think I found the issue, if you update this PR with diff --git a/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java b/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java
index 9308efd..9cf75c7 100644
--- a/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java
+++ b/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java
@@ -48,7 +48,7 @@ public class Certificates {
pemWriter.writeObject(cert);
pemWriter.flush();
}
- return certWriter.toString();
+ return certWriter.toString().replaceAll("\r\n", "\n");
}
/** Convert a certificate to a PEM encoded certificate. */
@@ -94,7 +94,7 @@ public class Certificates {
}
pemWriter.flush();
}
- return certWriter.toString();
+ return certWriter.toString().replaceAll("\r\n", "\n");
}essentially stripping out the |
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Contributor
Author
|
It seems to still fail, sadly https://github.com/keastrid/sigstore-java/actions/runs/15332645105/job/43142891162 |
Member
|
Yeah that's against the latest release. It's fine. If you comment out the release build for Windows you can see it pass on the dev build. But I would leave it in. We can probably think about publishing a fixed version soon |
loosebazooka
approved these changes
May 30, 2025
Member
|
thanks for this @keastrid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demonstration of #973 and testing to make sure it won't occur again by running in CI
Release Note
NONE
Documentation
No documentation changes needed