Conversation
Signed-off-by: Appu Goundan <appu@google.com>
d026b89 to
72335c6
Compare
aaronlew02
approved these changes
Jun 6, 2025
vlsi
reviewed
Nov 11, 2025
| - main | ||
| workflow_call: # allow this workflow to be called by other workflows | ||
| branches: [main] | ||
| pull_request: {} |
Collaborator
There was a problem hiding this comment.
This effectively removed execution of Test workflows for external contributors
Member
Author
There was a problem hiding this comment.
pull_request: {} seems fine to me?
I think the external contributors test is skipped with our @EnabledIfOidcExists (when oidc doesn't exist for these via github) -- we can make these tests at least check by using the conformance token or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we were running a lot of redundant checks here. Match what we do in other sigstore repos.