feat: accept markdown_text argument from the say helper#1372
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ai-apps #1372 +/- ##
==========================================
Coverage ? 91.00%
==========================================
Files ? 222
Lines ? 7512
Branches ? 0
==========================================
Hits ? 6836
Misses ? 676
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mwbrooks
approved these changes
Sep 24, 2025
Member
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looking solid to me!
🧪 Thanks for adding test coverage for markdown_text as well!
Member
Author
|
@mwbrooks Kind thanks! Right now the tests are stalling for Once these are passing I'll merge this 🚢💨 |
3 tasks
Member
Author
|
@mwbrooks The tests are now passing so we should merge this and follow up with more change I think 🚢 💨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR accepts the
markdown_textattribute in thesayhelper.The
chat.postMessagemethod accepts "markdown_text" separate from "text" and because empty arguments are removed, the defaulttextvalue for thesayhelper doesn't cause issue in testing.Testing
Clone a template app and add the following to a message listener:
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.