fix: aiohttp test_init_with_loop broken test#1697
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 113 113
Lines 12808 12808
=======================================
Hits 10930 10930
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM! And thanks for a fast find and fix 🙏 ✨
I notice we're using a ranged version for testing requirements which seems alright, though I'm wondering if we might want to pin this to the current latest and attempt updates on a schedule?
AFAICT we run tests with the latest but I'm not sure if we're signaling support for earlier versions with this? No blocker - all questions! 🚢 💨
|
Yess this is something I think I will bring up internally 💯 Having some sort of regression testing may help us detect broken tests like this before they are triggered by unrelated changes |
Summary
tests/slack_sdk_async/socket_mode/test_aiohttp.py:test_init_with_loopwas broken byaiohttpversion 3.12.6 with the following errorThe test aims to validate that a
loopcan be passed to theSocketModeClient, previously a new loop was created and passed to theSocketModeClientconstructor, this PR changes this behavior by passing the existing loop related to the unit tests.Testing
N/A
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.