Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ai-apps #1746 +/- ##
==========================================
Coverage ? 84.94%
==========================================
Files ? 113
Lines ? 12916
Branches ? 0
==========================================
Hits ? 10972
Misses ? 1944
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Everything looks good on my side! Great work, again, @zimeg! 🙇🏻
🧪 We discussed offline to add the tests later, since this feature isn't fully complete. We have a task, so tests will be added before this is brought into main.
@srtaalej feel empowered to hit that Approve button if you're confident in the code changes 😄 @zimeg deserves multiple approvals from time-to-time 😉
| loading_messages: Optional[List[str]] = None, | ||
| **kwargs, | ||
| ) -> AsyncSlackResponse: | ||
| """Revokes a token. |
There was a problem hiding this comment.
praise: Oof, thanks for catching this typo (and the ones following).
There was a problem hiding this comment.
@mwbrooks Thank you! I was debating opening a separate PR but am wanting to do a much more thorough pass for such 📚
There was a problem hiding this comment.
No worries, since it's internal cleanup and the PR is small, it didn't distract from the core changes in the PR 😄 You made the right call!
Summary
This PR adds an optional
loading_messagesattribute to theassistant.threads.setStatusmethod.Testing
WIP.
Category
Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.