fix(web-api): use json content type for chat stream methods#1749
Merged
fix(web-api): use json content type for chat stream methods#1749
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ai-apps #1749 +/- ##
==========================================
Coverage ? 84.98%
==========================================
Files ? 113
Lines ? 12944
Branches ? 0
==========================================
Hits ? 11000
Misses ? 1944
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@mwbrooks Appreciate it! Let's merge this with passing tests to unblock findings elsewhere 🧪 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows #1745 to use
jsoninstead ofparamsas the content type for chat stream methods. Reference.Fixes an issue where nested attributes - such as
blocks- weren't parsed as expected. 🐛Category
Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.