Skip to content

chore(claude): remove a trailing comma for valid setting parsing#313

Merged
zimeg merged 2 commits intomainfrom
zimeg-chore-claude-fix-json
Jan 28, 2026
Merged

chore(claude): remove a trailing comma for valid setting parsing#313
zimeg merged 2 commits intomainfrom
zimeg-chore-claude-fix-json

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jan 28, 2026

Summary

This PR removes a trailing comma from Claude settings for startups without error:

 Settings Error

 /path/to/programming/tools/slack-cli/.claude/settings.json
  └ Invalid or malformed JSON

 Files with errors are skipped entirely, not just the invalid settings.

 ❯ 1. Exit and fix manually
   2. Continue without these settings

 Enter to confirm · escape to cancel

Requirements

@zimeg zimeg added this to the Next Release milestone Jan 28, 2026
@zimeg zimeg self-assigned this Jan 28, 2026
@zimeg zimeg requested a review from a team as a code owner January 28, 2026 22:53
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Jan 28, 2026
@zimeg zimeg enabled auto-merge (squash) January 28, 2026 22:53
mwbrooks
mwbrooks approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for catching this! 🙇🏻

@zimeg zimeg merged commit 51219cf into main Jan 28, 2026
7 checks passed
@zimeg zimeg deleted the zimeg-chore-claude-fix-json branch January 28, 2026 23:08
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.83%. Comparing base (7010c3b) to head (4f1e0e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   64.85%   64.83%   -0.03%     
==========================================
  Files         212      212              
  Lines       17538    17538              
==========================================
- Hits        11374    11370       -4     
- Misses       5094     5098       +4     
  Partials     1070     1070

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

Assignees

@zimeg zimeg

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Milestone

v3.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg @mwbrooks

Comments