README: clarify limitations to workflow builder approach#228
Merged
seratch merged 1 commit intoslackapi:mainfrom Jul 21, 2023
Merged
README: clarify limitations to workflow builder approach#228seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @ryan-williams to sign the Salesforce Inc. Contributor License Agreement. |
|
Hi @ryan-williams! Thanks for the submission. Since @seratch was part of the original discussion that this change cites, awaiting his confirmation that this change is good to go prior to merging. |
seratch
approved these changes
Jul 21, 2023
Contributor
seratch
left a comment
There was a problem hiding this comment.
Thanks for making the change. LGTM
PhuongTMR
pushed a commit
to PhuongTMR/slack-github-action
that referenced
this pull request
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previously docs described "Technique 1" as "the recommended way to use this action", but that doesn't make sense given it doesn't support any text or message formatting (cf. #192 (comment)). This attempts to make that limitation clearer, cc @seratch.
Requirements (place an
xin each[ ])