ci(security): require access checks to pass before running unit tests#279
Merged
zimeg merged 2 commits intoslackapi:mainfrom Jan 16, 2024
Merged
ci(security): require access checks to pass before running unit tests#279zimeg merged 2 commits intoslackapi:mainfrom
zimeg merged 2 commits intoslackapi:mainfrom
Conversation
Member
Author
|
@filmaj appreciate the speedy review very much 🙇 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR requires the
access_checkstep to pass before runningunit_teststo prevent unexpected changes from branched PRs happening in actions.A note about the
access_checkis also added to the workflow file.Requirements