packages/backend/src/repoCompileUtils.ts (1)

64-64: Consider applying trailing-slash normalization consistently to all providers.

GitHub (line 64), Gitea (line 245), Gerrit (line 312), and Bitbucket (line 399) lack the same normalization. For those providers, trailing slashes in hostUrl don't currently produce double-slash URLs (webUrls come from API responses, not string concatenation), but the stored external_codeHostUrl would be inconsistently formatted across providers. Normalizing all providers defensively prevents the same class of bug if URL construction patterns change.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/backend/src/repoCompileUtils.ts` at line 64, The hostUrl for GitHub
(const hostUrl = config.url ?? 'https://github.com'), Gitea, Gerrit, and
Bitbucket blocks should be normalized the same way as other providers to avoid
inconsistent trailing slashes; add or reuse a small helper (e.g.,
normalizeHostUrl or stripTrailingSlash) and apply it to the hostUrl value in
each provider before storing external_codeHostUrl and any URL construction,
ensuring the stored external_codeHostUrl has a consistent format across
providers.

packages/backend/src/repoCompileUtils.ts (1)

90-103: Defensively normalize hostUrl inside createGitHubRepoRecord to prevent external callers from storing un-normalized host URLs.

The function is exported and accepts hostUrl as input. While compileGithubConfig normalizes the URL before calling (line 64), and the hardcoded call in api.ts uses a normalized URL, the exported function stores the raw hostUrl in external_codeHostUrl (line 117) without validation. An external caller could pass a trailing-slash URL that would be stored unchanged.

🛡️ Proposed defensive normalization

 export const createGitHubRepoRecord = ({
     repo,
     hostUrl,
     branches,
     tags,
     isAutoCleanupDisabled,
 }: {
     repo: OctokitRepository,
     hostUrl: string,
     ...
 }) => {
-    const repoNameRoot = new URL(hostUrl)
+    const normalizedHostUrl = hostUrl.replace(/\/+$/, '');
+    const repoNameRoot = new URL(normalizedHostUrl)
         .toString()
         .replace(/^https?:\/\//, '');

And replace all subsequent uses of hostUrl within the function body with normalizedHostUrl.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/backend/src/repoCompileUtils.ts` around lines 90 - 103,
createGitHubRepoRecord currently accepts hostUrl and stores it raw into
external_codeHostUrl; defensively normalize hostUrl at the start of
createGitHubRepoRecord (e.g., construct a URL object from hostUrl and derive a
normalized string like url.origin or strip trailing slash) and assign that to a
new normalizedHostUrl variable; then replace subsequent uses of hostUrl
(including where external_codeHostUrl is set and where repoNameRoot is created)
with normalizedHostUrl so callers cannot store an un-normalized URL.