Fix typos in variable and protected method names#177
Merged
goneall merged 1 commit intospdx:masterfrom Dec 16, 2024
Merged
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Member
This should be safe - I don't know of anyone extending the protected compare classes. Since we are introducing a lot of breaking changes with the spec 3 update, this is a good time to make these changes. |
goneall
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packagComparers->packageComparersexludeFilesToString->excludeFilesToStringorg.spdx.tools.compare.PackageSheetaccessing this method, outside of this package, it may not safe to be renamed