Skip to content

Introduce MultiValueMapCollector for use with streams#35958

Closed
florianhof wants to merge 2 commits intospring-projects:mainfrom
florianhof:feature/spring-data-commons-3420_MultiValueMapCollector_public
Closed

Introduce MultiValueMapCollector for use with streams#35958
florianhof wants to merge 2 commits intospring-projects:mainfrom
florianhof:feature/spring-data-commons-3420_MultiValueMapCollector_public

Conversation

@florianhof
Copy link
Contributor

@florianhof florianhof commented Dec 3, 2025

Stream's collector for building a MultiValueMap.

Mostly copied from spring-data-commons, see spring-projects/spring-data-commons#3420

I add the type parameters description, the static method indexingBy and the unit test.

@florianhof
spring-data-commons#3420 MultiValueMapCollector public
5bbf7e7 
Signed-off-by: Florian Hof <florian.hof@sbb.ch>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 3, 2025
@florianhof florianhof mentioned this pull request Dec 3, 2025
Closed
@sbrannen sbrannen changed the title spring-data-commons#3420 MultiValueMapCollector public Introduce MultiValueMapCollector for use with streams Dec 4, 2025
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Dec 4, 2025
@florianhof
spring-data-commons#3420 MultiValueMapCollector public - fix style
9921320 
Signed-off-by: Florian Hof <florian.hof@sbb.ch>
@florianhof
Copy link
Contributor Author

florianhof commented Dec 5, 2025 •
edited
Loading

Try to fix the the style problems...
I don't understand the problem of missing Signed-off-by because my 2 commits have them.
Would it be ok if I backport it in the 6.2.x branch?

@sbrannen sbrannen self-assigned this Dec 9, 2025
@sbrannen sbrannen added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 9, 2025
@sbrannen sbrannen added this to the 7.0.2 milestone Dec 9, 2025
@sbrannen
Copy link
Member

sbrannen commented Dec 9, 2025

I don't understand the problem of missing Signed-off-by because my 2 commits have them.

I set the DCO to pass. 👍

Would it be ok if I backport it in the 6.2.x branch?

Since we are now very late in the 6.2.x line, we typically do not introduce new features there. So I'll process this for main (7.0.2).

sbrannen pushed a commit that referenced this pull request Dec 10, 2025
@florianhof @sbrannen
Introduce MultiValueMapCollector for use with streams
bfc02cd 
See spring-projects/spring-data-commons#3420
See gh-35958

Signed-off-by: Florian Hof <florian.hof@sbb.ch>
@sbrannen sbrannen closed this in 3731fed Dec 10, 2025
@sbrannen
Copy link
Member

sbrannen commented Dec 10, 2025

This has been merged into main in bfc02cd and revised in 3731fed.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sbrannen sbrannen

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

Projects

None yet

Milestone

7.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@florianhof @sbrannen @spring-projects-issues