[6.x] Fix Spacer fieldtype collapse behaviour#13985
Merged
jasonvarga merged 5 commits into6.xfrom Feb 18, 2026
Merged
Conversation
…r to have extra height on small screens vs a standard field
…t serve a purpose here
the alternative to avoid the text would be to create an empty SpacerFieldtype component but that's unnecessary overhead.
Member
The whole reason that text is there is to see when you are using an invalid component. We want it to show. For the spacer fieldtype though, we were just making it invisible. The text was still there. I've avoided rendering the text now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
There are a couple of problems with the spacer field at lower viewports, described here #13983
What this PR Does
Taller Spacer Field (Before)
The spacer fieldtype had some extra text which meant it was "taller" than other fields at smaller viewports. Here it is around 78px vs the 66px height of a standard field, causing the row here to be taller than usual.
Taller Spacer Field (After)
The spacer should now be no taller than the other fields (66px here)
Gap (Before)
Gap (After)
How to Reproduce