Skip to content

Comments

[6.x] Fix clipped floating bard toolbar in replicators#14007

Merged
jasonvarga merged 3 commits into6.xfrom
fix-clipped-floating-bard-toolbar-in-replicators
Feb 20, 2026
Merged

[6.x] Fix clipped floating bard toolbar in replicators#14007
jasonvarga merged 3 commits into6.xfrom
fix-clipped-floating-bard-toolbar-in-replicators

Conversation

@jaygeorge
Copy link
Contributor

@jaygeorge jaygeorge commented Feb 19, 2026 •
edited
Loading

Description of the Problem

We recently removed motion. This PR should fix the replaced overflow clipping logic reported in #13997, which was slightly different to the working motion version.

What this PR Does

  • contain-paint should only be used on the outer set when it's collapsed
  • For replicators I've:
    • Replaced contain-paint with overflow-clip for replicator sets, restoring a change made previously (4be1d9d)
    • overflow-clip should only be added once the set is collapsed
  • Fixes Clipping issue on floating bard toolbar #13997

Before

2026-02-19 at 18 04 44@2x

After

2026-02-19 at 18 04 31@2x

How to Reproduce

  1. Add replicator field to your pages blueprint
  2. Add a bard field to that replicator - set Toolbar Mode to Floating
  3. Create entry, add replicator, enter content in bard, select text to make toolbar appear.

@jasonvarga
Copy link
Member

jasonvarga commented Feb 19, 2026

Can you clarify why the bard set and replicator set get different treatments?

@jaygeorge
Switch from overflow-clip to contain-paint, the same as bard/Set.vue.…
619ce95 
… This is more performant for rendering, and I think it should be safe to use that because it's only applied to sets when they're closed.
@jaygeorge
Copy link
Contributor Author

jaygeorge commented Feb 20, 2026 •
edited
Loading

Reasoning

  • Jack had initially changed just the replicator set value from contain-paint to overflow-clip in 4be1d9d26c777b9571b87bff5c87ce6075c1807c.
  • I think Jack did that because previously contain paint; was also in effect when the set was open.
  • I just kept that previous behaviour for simplicity but to be honest we should try to use contain: paint where possible since it improves rendering performance vs overflow: clip so…

Update

I've just updated replicator to use contain: paint too. I think it should be safe to use that because it's only applied to sets when they're closed.

@jasonvarga jasonvarga merged commit b0116b3 into 6.x Feb 20, 2026
11 checks passed
@jasonvarga jasonvarga deleted the fix-clipped-floating-bard-toolbar-in-replicators branch February 20, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clipping issue on floating bard toolbar

2 participants

@jaygeorge @jasonvarga