Closed
Conversation
# Conflicts: # package-lock.json # package.json # resources/js/app.js # resources/js/bootstrap/components.js # resources/js/components/data-list/Filter.vue # resources/js/components/fieldsets/Listing.vue # resources/js/components/fieldtypes/DictionaryFieldtype.vue # resources/js/components/fieldtypes/RadioFieldtype.vue # resources/js/components/fieldtypes/bard/LinkToolbar.vue # resources/js/components/fieldtypes/bard/Set.vue # resources/js/components/fieldtypes/replicator/Set.vue # resources/js/components/nav/Builder.vue # resources/js/components/nav/ItemEditor.vue # resources/js/components/users/Wizard.vue
# Conflicts: # package-lock.json # package.json # resources/js/components/AddonDetails.vue # resources/js/components/SessionExpiry.vue # resources/js/components/ToastBus.js # resources/js/components/assets/Uploader.vue # resources/js/components/collections/Listing.vue # resources/js/components/entries/Listing.vue # resources/js/components/fieldtypes/assets/AssetsFieldtype.vue
# Conflicts: # resources/js/components/assets/Browser/Browser.vue # resources/js/components/assets/Selector.vue # resources/js/components/assets/Upload.vue # resources/js/components/assets/Uploader.vue # resources/js/components/entries/PublishForm.vue # resources/js/components/fields/Settings.vue # resources/js/components/fieldtypes/FilesFieldtype.vue # resources/js/components/fieldtypes/assets/AssetsFieldtype.vue # resources/js/components/terms/PublishForm.vue
# Conflicts: # package-lock.json # package.json # resources/js/app.js # resources/js/bootstrap/components.js # resources/js/bootstrap/fieldtypes.js # resources/js/components/DropdownList.vue # resources/js/components/Statamic.js # resources/js/components/assets/Uploader.vue # resources/js/components/blueprints/TabContent.vue # resources/js/components/fieldtypes/AssetFolderFieldtype.vue # resources/js/components/fieldtypes/ButtonGroupFieldtype.vue # resources/js/components/fieldtypes/CodeFieldtype.vue # resources/js/components/fieldtypes/ColorFieldtype.vue # resources/js/components/fieldtypes/FilesFieldtype.vue # resources/js/components/fieldtypes/GroupFieldtype.vue # resources/js/components/fieldtypes/TableFieldtype.vue # resources/js/components/fieldtypes/bard/BardFieldtype.vue # resources/js/components/fieldtypes/grid/Grid.vue # resources/js/components/fieldtypes/grid/Stacked.vue # resources/js/components/fieldtypes/markdown/MarkdownFieldtype.vue # resources/js/components/fieldtypes/replicator/AddSetButton.vue # resources/js/components/fieldtypes/replicator/Field.vue # resources/js/components/fieldtypes/replicator/Replicator.vue # resources/js/components/fieldtypes/replicator/Set.vue # resources/js/components/inputs/relationship/InlinePublishForm.vue # resources/js/components/publish/Container.vue # resources/js/components/publish/Field.vue # resources/js/components/structures/PageEditor.vue
it goes against the vue3 convention, but it should make migrating fieldtypes much simpler.
Merged
Member
Author
|
Closing in favor of #11339. Thank you for your hard work! We really appreciate it. We'll be sure to credit you guys in there. We'll be cherry picking from this branch. We wanted to be able to have a cleaner slate where all formatting changes aren't mixed throughout the PR so if we need to look back in the history it would make more sense to us. We'll probably have a separate PR that applies standardized formatting/linting in one go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades from Vue 2 to 3.
Todos: (Obviously not a complete list)
Statamic.darkModeis not reactive