Skip to content

Comments

[4.x] Ability to disable CP authentication#7617

Closed
duncanmcclean wants to merge 9 commits intostatamic:4.xfrom
duncanmcclean:feature/disable-login-and-reset-password-pages
Closed

[4.x] Ability to disable CP authentication#7617
duncanmcclean wants to merge 9 commits intostatamic:4.xfrom
duncanmcclean:feature/disable-login-and-reset-password-pages

Conversation

@duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Feb 27, 2023

This pull request adds a new configuration option, allowing developers to disable CP authentication.

Use case

This may come in helpful for sites where you already have login implemented (via Nova, Jetstream, other means) and you don't want Statamic to have it's own login / password reset pages.

@duncanmcclean duncanmcclean marked this pull request as ready for review February 27, 2023 21:25
@duncanmcclean duncanmcclean changed the title Disable CP Authentication Ability to disable CP authentication Feb 27, 2023
@what-the-diff
Copy link

what-the-diff bot commented Apr 25, 2023 •
edited
Loading

PR Summary

  • Added configuration to disable Control Panel authentication routes
    The PR introduces an option to disable the Control Panel authentication routes, allowing improved control and customization.

  • Updated AuthenticationException handling for disabled routes
    The AuthenticationException::toResponse() method has been updated to handle disabled authentication routes correctly, ensuring smooth functionality.

  • Fixed and improved LoginFormTest for disabled auth routes
    The LoginFormTest has been fixed to work with disabled authentication routes, and additionally, a new test has been added to ensure proper behavior in such scenarios.

@edalzell edalzell changed the base branch from 3.4 to 4.x May 20, 2023 01:12
@edalzell edalzell changed the title Ability to disable CP authentication [4.x] Ability to disable CP authentication May 20, 2023
@edalzell edalzell marked this pull request as draft May 20, 2023 01:26
@duncanmcclean duncanmcclean mentioned this pull request Nov 9, 2023
Merged
@duncanmcclean duncanmcclean deleted the feature/disable-login-and-reset-password-pages branch November 9, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@duncanmcclean @edalzell