You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In "SVN Repositories" view if branch name contains more than 6 digits in a row, in some circumstances exception occurres when trying to open a tree:
java.lang.IllegalArgumentException: Comparison method violates its general contract!
Workaround for comparator violation:
Set system property -Djava.util.Arrays.useLegacyMergeSort=true
this: org.tigris.subversion.subclipse.ui.repository.RepositorySorter
comparator: java.text.RuleBasedCollator
Detailed stacktrace is:
java.lang.IllegalArgumentException: Comparison method violates its general contract!
at java.base/java.util.TimSort.mergeHi(TimSort.java:903)
at java.base/java.util.TimSort.mergeAt(TimSort.java:520)
at java.base/java.util.TimSort.mergeCollapse(TimSort.java:448)
at java.base/java.util.TimSort.sort(TimSort.java:245)
at java.base/java.util.Arrays.sort(Arrays.java:1233)
at org.eclipse.jface.viewers.ViewerComparator.sort(ViewerComparator.java:206)
I provided a solution and also added system property to be able to disable complex "revision" comparison of branch names in eclipse.ini.
It would be great if someone check this fix and merge into master branch.
Given that you provided a solution, what was the reason behind the second part of this change?
Sorry for the late response. Actually, the first thing i did when i faced a given issue and didn't want to check all comparison logic, was disabling it with a flag and "patching" a jar inside my eclipse installation. Only after I had some free time to actually dive into that logic, I provided a fail-safe solution, but didn't remove a flag, as logic still remains a bit tricky in my opinion.
P.S. Thanks for merging into master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "SVN Repositories" view if branch name contains more than 6 digits in a row, in some circumstances exception occurres when trying to open a tree:
java.lang.IllegalArgumentException: Comparison method violates its general contract!
Workaround for comparator violation:
Set system property -Djava.util.Arrays.useLegacyMergeSort=true
this: org.tigris.subversion.subclipse.ui.repository.RepositorySorter
comparator: java.text.RuleBasedCollator
Detailed stacktrace is:
java.lang.IllegalArgumentException: Comparison method violates its general contract!
at java.base/java.util.TimSort.mergeHi(TimSort.java:903)
at java.base/java.util.TimSort.mergeAt(TimSort.java:520)
at java.base/java.util.TimSort.mergeCollapse(TimSort.java:448)
at java.base/java.util.TimSort.sort(TimSort.java:245)
at java.base/java.util.Arrays.sort(Arrays.java:1233)
at org.eclipse.jface.viewers.ViewerComparator.sort(ViewerComparator.java:206)
I provided a solution and also added system property to be able to disable complex "revision" comparison of branch names in eclipse.ini.
It would be great if someone check this fix and merge into master branch.