Azure Queue Storage Source - Add Visibility timeout parameter#1383
Azure Queue Storage Source - Add Visibility timeout parameter#1383FranBarrera merged 6 commits intotriggermesh:mainfrom
Conversation
|
nit: k8s' |
I agree on having something consistent across the components but go time is language specific, while ISO is a standard. Knative uses ISO for durations too: https://knative.dev/docs/eventing/event-delivery/#configuring-subscription-event-delivery |
|
Go time format is natively supported by k8s, so I don't see why we can't keep using it. Personally, I'm not a fan of the ISO format because it's not intuitive, but having the same attributes declared in different formats is even worse than that. Hence, if you think that switching to the ISO is essential and worth introducing breaking change, then go for it. Hopefully, we will not follow Knative's specification style in the future. |
|
Ok, no problem, I'll revert it to go time and then we can discuss what standard we should use |
|
That works for me, thank you. I noticed that the core k8s components use |
* Azure Queue Storage Source - Add visibility timeout parameter * Azure Queue Storage Source - Add visibility timeout parameter * Check timeout is a maximum of 7 days * Change to go time * Fix go.mod * Add sample
|
@FranBarrera any chance we can get some better documentation for the attribute to appear in the CRD? |

Closes #1382
This PR adds a new optional parameter to set the visibility timeout to Azure Queue Storage Source following the ISO8601, more info: https://en.wikipedia.org/wiki/ISO_8601