This repository was archived by the owner on Nov 5, 2024. It is now read-only.
AWSS3Source - Fix client to use iamRole#1401
Merged
FranBarrera merged 1 commit intotriggermesh:mainfrom Apr 28, 2023
Merged
Conversation
tzununbekov
approved these changes
Apr 28, 2023
Member
tzununbekov
left a comment
There was a problem hiding this comment.
@FranBarrera did you figure out why previous version didn't work? I'm not quite sure what was changed in this PR from functional point of view
Contributor
Author
|
@tzununbekov Yes, the problem was with this code: https://github.com/triggermesh/triggermesh/pull/1401/files#diff-c1ccaf7d16fe601df5071a72ffe5d1c25c8953ce39807b3a2fba4d480183f485L90-L91 That code was failing to get the cred value, it was requiring to put our generated iam user in the users iam role trusted policy: This was the error in the triggermesh-controller: Now it works like the others AWS Sources and doesn't require extra permissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1396
Note:
This PR fix the issue with the aws client to use the
iamRolebut it's still needed to follow theEKS IAM Role Authinstructions explained in this PR: #1243