-
Notifications
You must be signed in to change notification settings - Fork 959
fix: skk.moe fetch method param #15692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently, |
|
does this help ?
|
|
@mapx- I am not entirely sure what this filter is based on (a key in the body?). I would like to find a way to stop a kind (verb) of request (reading a blog imo doesn't need to POST anything in the background), and right now I can't find any effective way to achieve this goal. |
|
Test for breakage
or
or
I see no POST anymore. |
|
|
|
And you are just breaking following page:
Those pages are using ECharts library which uses |
@gorhill this needs to be addressed... |
|
|
It doesn't. |
|
What filter doesn't work where? |
|
@gorhill Add |
|
The site uses an object with non-enumerable properties as the fetch's |
Let's leveling the playing field a little bit: one of the proper ways to do this is to use |
|
1.67.1b5 This version broke the test. https://www.cloudflare.com/ru-ru/ssl/encrypted-sni/#results |
URL(s) where the issue occurs
https://blog.skk.moe/Describe the issue
The params in the fetch is lower case while the filter is upper case.
Notes
I believe the root cause is because
no-fetch-ifdoes not support case insensitive (require extra params if build regex from string), while infetch()you could passPoStas method while still have correct behavior but bypass the filter. A separate issue for uBlock may be required.Related https://github.com/gorhill/uBlock/blob/b6ed83bc5c840431ed03cddaed1daeb395db3b0e/assets/resources/scriptlets.js#L609