Attempt to improve function under-application and over-application errors#5665
Merged
Attempt to improve function under-application and over-application errors#5665
Conversation
f7c88c8 to
0afcd23
Compare
Member
|
Wow, awesome!!! |
0afcd23 to
d35c9c5
Compare
d35c9c5 to
c4cd6f0
Compare
aryairani
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Uses heuristics to detect function over and under application and provide better information on how to fix it.
Under-applied:
Before:

After:

And a case where a function is over-applied.
Before

After

Implementation notes
Interesting/controversial decisions
There may be cases where this is incorrect, but I think the benefit is worth that risk, we can dogfood it and tweak or roll-back as needed.
Test coverage
See new transcripts