tweak: don't bother synhashing when synhashes would be the same#5718
Merged
mitchellwrosen merged 41 commits intotrunkfrom Aug 29, 2025
Merged
tweak: don't bother synhashing when synhashes would be the same#5718mitchellwrosen merged 41 commits intotrunkfrom
mitchellwrosen merged 41 commits intotrunkfrom
Conversation
Contributor
Nice! |
aryairani
approved these changes
Aug 19, 2025
Contributor
aryairani
left a comment
There was a problem hiding this comment.
What sort of coordination has to happen between merging this PR and the Share one?
Member
Author
|
@aryairani We'd be unable to bump the unison dep until the Share PR is ready, so I think this should wait until that one is reviewed & ready to merge. (Almost ready to mark it as ready for review). |
Contributor
|
Share PR is here: unisoncomputing/share-api#134 |
Contributor
|
Nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a "narrowing" step to diff/merge. Previously, we'd compute the syntactic hash of every type and term in a namespace, then perform a diff on those hashes. Now, we avoid computing the syntactic hash of terms and types that we know (by their Unison hash) are equal. This allows us to skip a lot of work for diffs/merges that don't transitively touch a lot of definitions, such as those that contain only new definitions.
Additionally, this PR and speeds up definition loading in general by utilizing branch/names caches that were added recently in
updatework. Previously, we'd load all branches involved from scratch (and that's where the conflicted names check was implemented). But this was always slower than going the other direction – using the pre-builtNamesin theBranchobject as a starting point, and checking it for conflicted names. Sinceupdatenow does something similar, I deleted all of the old slow loading code and reworked the starting point of diff/merge to basically be "given branches that are not conflicted, ...".The merge-as-a-library API was simplified down to just two steps, diff (producing a diffblob) and merge (producing a mergeblob). Previously, there were many more steps of pure functions interspersed with database calls, but now those two steps just take a couple callbacks that load defnitions, names, whatever is needed.
I also deleted (& sort of inlined into Share) the "human diffs" calculation, as only Share uses it, so it doesn't need to be in the UCM side. I switched the "renames" field of the diff to only include "simple" renames (one name to one other name), since that's what we'll (try to) incorporate into merge.
A performance number: computing the diff for a small change to
@unison/base, which includes an add and an update with 5 or so transitive dependents, used to take 13 seconds, and now takes ~0.2 seconds (and is instantaneous if repeated with the same inputs, because cache).Test coverage
Existing transcripts, and manual testing.