Merged
Conversation
Avoid duplicating the logic, and ensure we keep the test script working. This also fixes the guards on the `interpreter-tests` job steps and adds the workflow to the cache hashes.
The interpreter tests are broken by unisonweb#5819 which (wisely) fails `transcript.fork` when it’s run with the same source and target codebase. This updates the interpreter tests to use `transcript.in-place` instead. (cherry picked from commit dc61f22)
Contributor
Author
|
Ok, these are now failing because the cached codebase is out of date and needs to be migrated. Wondering how to manage that in CI.
I’m guessing |
If an explicit UCM isn’t specified, build before looking for the executable.
Contributor
Author
They’re fixed now (found |
aryairani
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The interpreter tests are broken by #5819 which (wisely) fails
transcript.forkwhen it’s run with the same source and target codebase. This updates the interpreter tests to usetranscript.in-placeinstead.Implementation notes
This also updates CI to use interpreter-tests.sh rather than duplicating the logic, so CI will catch similar in future. And it makes a couple other fixes to the CI job.
Test coverage
This fixes broken tests.