fix bad transcript caching and syntax error in mcp.md#5879
Merged
Conversation
although sometimes I wish we didn't test the docs/ transcripts in CI, because I often forget to re-run them, it's probably a good idea.
ChrisPenner
reviewed
Sep 16, 2025
| with: | ||
| path: ${{env.transcript_test_results}} | ||
| key: transcripts-results-${{ matrix.os }}-${{ hashFiles('**/ci.yaml', '**/stack.yaml', '**/package.yaml', '**/*.hs')}}-${{ hashFiles('**/unison-src/**/*.md', '**/unison-src/**/*.u') }} | ||
| key: transcripts-results-${{ matrix.os }}-${{ hashFiles('**/ci.yaml', '**/stack.yaml', '**/package.yaml', '**/*.hs')}}-${{ hashFiles('**/unison-src/**/*.md', '**/unison-src/**/*.u', '**/docs/*.md', '**/docs/*.markdown') }} |
Member
There was a problem hiding this comment.
This is a good idea, but maybe we should also just rename all the *.markdown -> *.md for consistency so this doesn't happen again in other scripts?
Contributor
Author
There was a problem hiding this comment.
I'm okay with that, cc @pchiusano who iirc is our instigator of unabbreviated file extensions 😉
ChrisPenner
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5877 (slack / introduced in https://github.com/unisonweb/unison/pull/5406/files#diff-5308f4957ea3a656ed6413eb5550467ad70d978be5db5c873c3486f336f4504bR181-R182)
fixes #5878 (slack / introduced in #5873)