Create a dedicated failure type for AsyncCancelled#5991
Conversation
This is similar to the behavior for `ThreadKilledFailure`. The idea is that inspecting for this is more stable than looking for `"AsyncCancelled"` in the message part of the `Failure`. I don't really know what I'm doing with adding builtins so I probably missed something.
I usually just run |
|
Or once it's already on Github, you can use the |
|
... and then manually re-run the CI workflow on it; since Github stops itself from rerunning it automatically after the update-transcripts workflow. It doesn't like starting work on commits that it itself created. |
|
@ceedubs Ok, well it's passing CI now 🙃 |
|
@aryairani fair question. I manually tested it and thought that I would add a transcript but then realized that I didn't know of a way to test this in a transcript. This is the exception that propagates if you send an interrupt signal to a Unison program (such as ctrl-c during a For manual testing I ran the following program and hit ctrl-c after a couple of seconds: This triggered the |
|
Yeah. I guess we can kill a process from Unison, but not fork one... I updated the PR instructions to ask for a screenshot of manual testing in the future 🫠 |
|
Here is the passing CI run for ca360df |
This is similar to the behavior for
ThreadKilledFailure. The idea is that inspecting for this is more stable thanlooking for
"AsyncCancelled"in the message part of theFailure.Replacement for #5988 that is on the main repo so @aryairani has more permissions to fix things, because I can't seem to get transcript output to line up. Do I need some sort of mcp tools on my machine or something?