disallow adding or updating things in lib with update#6083
Merged
mitchellwrosen merged 11 commits intotrunkfrom Jan 19, 2026
Merged
disallow adding or updating things in lib with update#6083mitchellwrosen merged 11 commits intotrunkfrom
update#6083mitchellwrosen merged 11 commits intotrunkfrom
Conversation
1 task
Contributor
|
|
aryairani
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5927
This PR makes
updatefail if the scratch file contains any additions of or updates to definitions inlib.*. It also warns on slurp, beforeupdatewhether anupdatewould fail for this reason.Test coverage
I've added a transcript that demonstrates the feature.