make alias.type name the constructors as well
#6099
Merged
+284
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f constructors already exist
aryairani
approved these changes
Jan 10, 2026
Contributor
There was a problem hiding this comment.
Looks good but re. transcripts, reminder to please optimize them for reading. Add some short text indicating what we're demonstrating (I think this part is already there) and what we're looking for in the output to know that it worked. Hide typechecking output (and probably most other output) unless reviewing the output is part of the feature or scenario being demonstrated. Otherwise the demo is lost in the noise like in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes
alias.typealso alias constructors (of non-builtin types). For example withif you run
alias.type Foo Baryou'll end up with the aliasrather than (on trunk)
If a term already exists at any of the constructors' names, it'll fail with a "term already exists" error.
Test coverage
Transcript included