Add some better implementations for some bytes reading/decoding functions #6104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchiusano
approved these changes
Jan 9, 2026
Member
pchiusano
left a comment
There was a problem hiding this comment.
Great!
Do all the existing tests in base pass with this?
Contributor
Author
|
Base tests pass. |
aryairani
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds builtin replacements for various
Bytes.readfunctions as requested in #6100.I also took the opportunity to switch to the dedicated endian-fixing functions (instead of manual shift-and-or on bytes) for the assorted
decodeNat64belike builtins, because I'd built the infrastructure for the replacements.Pretty straight forward once I decided on a way to do the indexing. I'm not sure it's the absolutely fastest way to handle things, but every other idea I had for dealing with values that span multiple chunks was a lot more complicated.