Merged
Conversation
aryairani
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5974
This PR improves the error message we see on ambiguous
run.Previously,
runwould crash with a bad error message whenever given an ambiguous suffix, even if not all matching names were of the right type.Now,
runfirst filters the list of candidate terms down to the ones that have the right type, and then runs if there's only one, otherwise fails with a decent error message. Like other commands, indirect dependencies are in scope but don't contribute to ambiguous name errors.Test coverage
I've included a transcript that demonstrates the changes